Skip to content

[5.1] Sync NSData+DataProtocol from the SDK overlay #2620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 24, 2020

Conversation

spevans
Copy link
Contributor

@spevans spevans commented Jan 21, 2020

(cherry picked from commit 11ce111)

This fixes a bug with computing the offset.

cc @kevints

@spevans
Copy link
Contributor Author

spevans commented Jan 21, 2020

@swift-ci test

@spevans spevans changed the title Sync NSData+DataProtocol from the SDK overlay [5.1] Sync NSData+DataProtocol from the SDK overlay Jan 21, 2020
@spevans
Copy link
Contributor Author

spevans commented Jan 24, 2020

cc @kevints @weissi

Copy link
Contributor

@weissi weissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, LGTM!

@weissi
Copy link
Contributor

weissi commented Jan 24, 2020

@spevans is this also in 5.2?

@spevans
Copy link
Contributor Author

spevans commented Jan 24, 2020

Yes, this has been merged into 5.2

@weissi weissi merged commit 0af915c into swiftlang:swift-5.1-branch Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants