Base: reorder includes for Windows (NFCI) #2623
Conversation
This reorders the Windows header includes for `LARGE_INTEGER` after PR swiftlang#2612.
|
CC: @3405691582 |
|
@swift-ci please test Linux platform |
| #define FD_SETSIZE 1024 | ||
| #include <winsock2.h> | ||
| #include <windows.h> | ||
| #include <time.h> |
There was a problem hiding this comment.
Don't forget time.h is included adjacent to mach_absolute_time.
(Not sure if you need to redef BOOL for time.h, or whether it's just simpler to include time.h twice here.)
There was a problem hiding this comment.
That needed to be shuffled due to the inclusion of Windows.h.
There was a problem hiding this comment.
What I mean is: can you omit it here again, considering now time.h is included a second time below windows.h, or is there some other reason preventing that?
There was a problem hiding this comment.
oh, I see; I'll do that as a follow up. The time.h was moved since it was in the block.
|
Optionally, it might be nice to bring up the boolean_t changes below into this block, but that might also be better to do in a separate PR sometime later down the line. |
This reorders the Windows header includes for
LARGE_INTEGERafterPR #2612.