Skip to content

[5.2] Backport of #2543 for Swift 5.2 branch #2652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 6, 2020
Merged

[5.2] Backport of #2543 for Swift 5.2 branch #2652

merged 2 commits into from
Feb 6, 2020

Conversation

Frizlab
Copy link
Contributor

@Frizlab Frizlab commented Feb 6, 2020

No description provided.

@weissi weissi requested a review from millenomi February 6, 2020 16:01
@weissi weissi mentioned this pull request Feb 6, 2020
Merged
@weissi weissi changed the title Backport of #2543 for Swift 5.2 branch [5.2] Backport of #2543 for Swift 5.2 branch Feb 6, 2020
phausler
phausler approved these changes Feb 6, 2020
View reviewed changes
Copy link
Contributor

@phausler phausler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine, but I would suggest perhaps tuning the sleep down a bit to avoid tests taking too long

@millenomi
Copy link
Contributor

Per discussion: let’s make any further changes on master. Good to merge once tests pass.

@weissi
Copy link
Contributor

weissi commented Feb 6, 2020

@swift-ci test

@millenomi millenomi merged commit 81023c5 into swiftlang:swift-5.2-branch Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phausler phausler phausler approved these changes

@millenomi millenomi Awaiting requested review from millenomi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Frizlab @millenomi @weissi @phausler