FileManager: correct symbolic link handling on Windows #2660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the symbolic link points across a drive, querying the symbolic link will provide a NT style path. The NT style path is not valid for a reparse point destination. Use a hand-rolled canonicalization (removal of the `\??\` prefix) for the path to get a path that we can use in the symbolic link. `NTPathToDosPath` is a possible approach to a more robust solution but relies on undocumented kernel APIs.
|
@swift-ci please test Linux platform |
1 similar comment
|
@swift-ci please test Linux platform |
|
@swift-ci please test Linux platform |
|
The Windows builds have passed, no regressions, and an improvement in the test pass rate on both. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the symbolic link points across a drive, querying the symbolic link
will provide a NT style path. The NT style path is not valid for a
reparse point destination. Use a hand-rolled canonicalization (removal
of the
\??\prefix) for the path to get a path that we can use in thesymbolic link.
NTPathToDosPathis a possible approach to a morerobust solution but relies on undocumented kernel APIs.