[CF] TARGET_OS_BSD for FS representation behavior. #2680
Conversation
CoreFoundation/URL.subproj/CFURL.c
Outdated
| #endif | ||
| #if TARGET_OS_MAC || TARGET_OS_LINUX | ||
|
|
||
| #if TARGET_OS_MAC || TARGET_OS_LINUX || TARGET_OS_BSD |
There was a problem hiding this comment.
Would it be better to make this an #if !TARGET_OS_WIN32 else this function will always return false when run on something that isn't a listed platform?
There was a problem hiding this comment.
CF only mentions kCFURLPOSIXPathStyle or kCFURLWindowsPathStyle(kCFURLHFSPathStyle is deprecated). So I think in this case your suggestion makes sense to make this a binary conditional.
However, we should probably invert sense in that case: TARGET_OS_WIN32 comes first, and POSIX is an #else.
CFURLGetFileSystemRepresentation's implementation has TARGET_OS_MAC and TARGET_OS_LINUX, but not TARGET_OS_BSD. Nothing here appears macOS or Linux specific, and things seem to work okay with TARGET_OS_BSD, so enable it here too. This also requires CanonicalFileURLStringToFileSystemRepresentation to be exposed.
3405691582
force-pushed
the
CFURL_FileSystemRepresentation
branch
from
388c172 to
6026766
Compare
|
@wift-ci test linux |
|
Looks like you typo'd the @ there :) |
|
@swift-ci please test Linux platform |
|
Can someone re-run this? The failure in the run looks unrelated. |
|
@swift-ci please test Linux platform |
|
I think that this is ready, lets get it merged. |
CFURLGetFileSystemRepresentation's implementation has TARGET_OS_MAC and
TARGET_OS_LINUX, but not TARGET_OS_BSD. Nothing here appears macOS or
Linux specific, and things seem to work okay with TARGET_OS_BSD, so
enable it here too.
This also requires CanonicalFileURLStringToFileSystemRepresentation to
be exposed.