Skip to content

build: use forced loading for FoundationNetworking #2683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 22, 2020

Conversation

compnerd
Copy link
Member

Since FoundationNetworking symbols are lazily resolved at runtime,
no symbol references to it are emitted. On PE/COFF targets (i.e.
Windows), this will result in FoundationNetworking not being loaded and
linked against. Use the force load symbol to ensure that the reference
is preserved.

@compnerd
Copy link
Member Author

@swift-ci please test Linux platform

Since FoundationNetworking symbols are lazily resolved at runtime,
no symbol references to it are emitted.  On PE/COFF targets (i.e.
Windows), this will result in FoundationNetworking not being loaded and
linked against.  Use the force load symbol to ensure that the reference
is preserved.
@compnerd
Copy link
Member Author

@swift-ci please test Linux platform

1 similar comment
@millenomi
Copy link
Contributor

@swift-ci please test Linux platform

@millenomi millenomi merged commit 3f1c097 into swiftlang:master Feb 22, 2020
@compnerd compnerd deleted the force-linking branch February 22, 2020 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants