[5.1] SR-11917: Using JSONEncoder's .outputFormatting = .sortedKeys has a memory leak on Linux #2693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emory leak on Linux - Any use of NSString.compare(_:options:range:locale:) with a non-nil locale would leak on Linux. - _CFCompareStringsWithLocale was leaking the collator on non-macOS platforms. - Use the collator cache on Linux and Win32 the same way that macOS does. (cherry picked from commit 1112582)
|
@swift-ci test |
|
@swift-ci test |
|
@spevans this one failed the macOS Platform test twice, any ideas? |
|
Looks to be unrelated since its python lint tests that are failing in the main swift repo. Note the macOS tests are normally ignored since they dont actually build swift-corelibs-foundation at all or run any of the tests - the CI really needs to be replaced for testing on macOS with something that does. |
|
@shahmishal can we merge this? (See @spevans 's comment) |
|
@swift-ci test macos |
|
This is targeting swift-5.1-branch, we don't currently have plan on releasing new toolchain for 5.1.x. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any use of NSString.compare(_:options:range:locale:) with a non-nil locale
would leak on Linux.
_CFCompareStringsWithLocale was leaking the collator on non-macOS
platforms.
Use the collator cache on Linux and Win32 the same way that macOS
does.
(cherry picked from commit 1112582)