Skip to content

Fix TestURLSession.test_noDoubleCallbackWhenCancellingAndProtocolFailsFast() #2724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2020

Conversation

spevans
Copy link
Contributor

@spevans spevans commented Mar 13, 2020

  • Darwin requires implementation of FailFastProtocol.canonicalRequest()
    to override abstract method in URLProtocol

  • Fix the error code from in the callback to be equal to NSURLErrorCancelled.

  • This test now passes on Darwin and Linux but is currently left disabled.

…sFast()

- Darwin requires implementation of FailFastProtocol.canonicalRequest()
  to override abstract method in URLProtocol

- Fix the error code from in the callback to be equal to NSURLErrorCancelled.

- This test now passes on Darwin and Linux but is currently left disabled.
@spevans
Copy link
Contributor Author

spevans commented Mar 13, 2020

@swift-ci test linux

@spevans spevans merged commit 9365168 into swiftlang:master Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant