Skip to content

Removed Linux use of sys/sysctl.h #2771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2020
Merged

Removed Linux use of sys/sysctl.h #2771

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CoreFoundation/PlugIn.subproj/CFBundle_InfoPlist.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@

#if (TARGET_OS_MAC || TARGET_OS_LINUX || TARGET_OS_BSD) && !TARGET_OS_CYGWIN
#include <dirent.h>
#if !TARGET_OS_ANDROID
#if TARGET_OS_MAC || TARGET_OS_BSD
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The call site for sysctlbyname is guarded by TARGET_OS_IPHONE, so perhaps use that here, too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, TARGET_OS_IPHONE wasn't included in the original code, I'm leery of adding anything that could cause unintended side effects.

#include <sys/sysctl.h>
#endif
#include <sys/mman.h>
Expand Down