SR-12696: Add JSONEncoder.OutputFormatting.withoutEscapingSlashes for Linux #2781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
spevans
commented
May 5, 2020
spevans
commented
- This was missing and is required to match Darwin.
|
@swift-ci test linux |
millenomi
reviewed
May 9, 2020
Sources/Foundation/JSONEncoder.swift
Outdated
| /// for security reasons, allowing outputted JSON to be safely embedded within HTML/XML. | ||
| /// In contexts where this escaping is unnecessary, the JSON is known to not be embedded, | ||
| /// or is intended only for display, this option avoids this escaping. | ||
| @available(OSX 10.15, iOS 13.0, watchOS 6.0, tvOS 13.0, *) |
There was a problem hiding this comment.
There are a bunch of available(… apple platforms …) tags strewn about SCF, but they're not relevant to SCF. (They really should be @available(swift 5.3…), etc.)
There was a problem hiding this comment.
Yeah I only copied them from the Foundation headers because there are @available annotations on other things. But I agree I dont see the point of them in SCF - even marking them for a specific swift version seems redundant since the code is tied to the specific branch anyway. I will remove these ones.
|
@swift-ci please test |
|
Testing again with the Catalina merge. |
… Linux - This was missing and is required to match Darwin.
|
@swift-ci test linux |
1 similar comment
|
@swift-ci test linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.