[CF] Rename remaining __kCFAllocatorTypeID_CONST. #2790
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR swiftlang#2782 references symbol __kCFAllocatorTypeID_CONST in CFRuntime.c but this was removed in swiftlang#1708. After interpreting the commit, it looks like this symbol was renamed to _kCFRuntimeIDCFAllocator. Therefore, make this rename again.
|
Why did this compile? |
|
If I'm looking at it right, CFRelease just passes through to swift_release when DEPLOYMENT_RUNTIME_SWIFT, but I've been experimenting with standalone CF builds, which means DEPLOYMENT_RUNTIME_SWIFT is not set and the rest of the body of CFRelease is not compiled. |
|
Ah, yeah, that makes sense. |
|
@swift-ci please test and merge |
1 similar comment
|
@swift-ci please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #2782 references symbol __kCFAllocatorTypeID_CONST in CFRuntime.c but
this was removed in #1708. After interpreting the commit, it looks like
this symbol was renamed to _kCFRuntimeIDCFAllocator. Therefore, make
this rename again.