Fix memory leak in function CFTimeZoneCreateWithName #2816
Conversation
| @@ -1594,6 +1594,7 @@ CFTimeZoneRef CFTimeZoneCreateWithName(CFAllocatorRef allocator, CFStringRef nam | |||
| #endif | |||
| CFRelease(dict); | |||
| if (CFEqual(CFSTR(""), name)) { | |||
| CFRelease(baseURL); | |||
| return NULL; | |||
There was a problem hiding this comment.
Is a CFRelease(data); also needed for the assignment on L1574?
There was a problem hiding this comment.
data is released on L1617.
There was a problem hiding this comment.
I meant if the return NULL on L1598 is reached then data wont have been released?
There was a problem hiding this comment.
You are right - there's codepath where data is allocated.
And also there's code path where baseURL isn't allocated.
So I fixed both.
There was a problem hiding this comment.
Ah good, catch. Could you revert the indentation commit since we want to avoid changing unrelated lines and then squash this all down to one commit, thanks. I think it should be ok then.
|
@swift-ci please test |
valeriyvan
force-pushed
the
CFTimeZoneLeak
branch
from
e837b67 to
2a1cbf1
Compare
valeriyvan
force-pushed
the
CFTimeZoneLeak
branch
from
2a1cbf1 to
a493212
Compare
|
@swift-ci test |
|
@swift-ci please test |
|
ping |
1 similar comment
|
ping |
No description provided.