Move all uses of Core Foundation to be @_implementationOnly except getCFRunLoop(). #2876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
cc @compnerd |
|
Test failure looks unrelated. |
|
@swift-ci please test linux |
…. Replace with unsafeBitCast() or other means as needed.
|
@swift-ci please test |
|
It was not unrelated. |
|
@swift-ci please test |
- HANDLE was being picked up transitively by CF's reexporting; import it explicitly - There was one CF type in a stored property in a #if os(Windows) block.
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
…e of these need to change vis-a-vis Darwin equivalents.)
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
|
Tests appear to be broken regardless of this patch. Pulling the PR brake. |
xwu
reviewed
Sep 22, 2020
| // SwiftFoundation | ||
| // | ||
| // Created by Aura Lily Vulcano on 8/27/20. | ||
| // Copyright © 2020 Swift. All rights reserved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CF headers and module are still required (because of getCFRunLoop()), but this makes them much easier to remove in the future.