Implement remaining NSDateFormatter attributes, with more tests #288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm, I'm a little nervous about commenting out some tests without fully understanding why they are failing. |
|
@parkera Thats understandable, I've sent an email out to the mailing list in order to figure out why I can't debug on Linux, but I have received no response. Another option is I revert |
tfrank64
force-pushed
the
default_dateFormatter
branch
from
54b6365 to
496a109
Compare
|
So I finally figured out the issue, it happened when I casted a |
|
@swift-ci Please test |
parkera
added a commit
that referenced
this pull request
Mar 21, 2016
Implement remaining NSDateFormatter attributes, with more tests
atrick
pushed a commit
to atrick/swift-corelibs-foundation
that referenced
this pull request
Jan 12, 2021
Fix a number of resource leaks when using SourceKit-LSP in tests or as a library
kateinoigakukun
pushed a commit
to kateinoigakukun/swift-corelibs-foundation
that referenced
this pull request
Oct 11, 2023
[pull] swiftwasm from main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SR-208 should be resolved with the additions of this PR and recent commit 8955678 setting of dateFormat.
In this PR:
.dateFormatvaluesAlso, tests will need PR #285 to actually run.