Foundation: explicitly convert value to Date
#2885
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no implicit conversion from `Int` to `Date`. The implicit cast fails, resulting in `nil` being returned for the `creationDate` property. Explicitly unwrap the result of the `.creationDate` attribute and use that to construct the `Date` to return. Partially addresses: SR-13617
|
@swift-ci please test |
|
CC: @spevans @millenomi |
xwu
reviewed
Sep 26, 2020
| get { | ||
| guard let timestamp: Int = _get(.creationDateKey) else { return nil } | ||
| return Date(timeIntervalSince1970: TimeInterval(timestamp)) | ||
| } |
There was a problem hiding this comment.
Wait, set doesn't have the corresponding issue?
There was a problem hiding this comment.
Thats actually why Im not 100% certain why this is needed. There are other Date accessors which should also see similar things? The test suite seems to be passing though, so Im not sure what is special here.
|
Okay, with the help from @millenomi this is no longer necessary (#2884 is the complete fix) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no implicit conversion from
InttoDate. The implicit castfails, resulting in
nilbeing returned for thecreationDateproperty. Explicitly unwrap the result of the
.creationDateattributeand use that to construct the
Dateto return.Partially addresses: SR-13617