Add URLSessionTaskMetrics #2886
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
@swift-ci please test Linux platform |
MaxDesiatov
reviewed
Sep 28, 2020
| @@ -128,6 +128,8 @@ public protocol URLSessionTaskDelegate : URLSessionDelegate { | |||
| func urlSession(_ session: URLSession, task: URLSessionTask, didCompleteWithError error: Error?) | |||
|
|
|||
| func urlSession(_ session: URLSession, task: URLSessionTask, willBeginDelayedRequest request: URLRequest, completionHandler: @escaping (URLSession.DelayedRequestDisposition, URLRequest?) -> Void) | |||
|
|
|||
| func urlSession(_ session: URLSession, task: URLSessionTask, didFinishCollecting metrics: URLSessionTaskMetrics) | |||
There was a problem hiding this comment.
nit: formatting seems to be inconsistent here
There was a problem hiding this comment.
The other formatting is inconsistent: the first two methods are indented 4 spaces, the others 5. 4 seems correct.
There was a problem hiding this comment.
Sure, the nit is about the rest of the code being inconsistent, not yours 😁
Good opportunity to make the rest of the functions in this protocol use 4-spaces indentation?
There was a problem hiding this comment.
Sure. Fixed all of the spacing issues in this file in 75bcd79.
This comment has been minimized.
This comment has been minimized.
1 similar comment
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starts fixing SR-11518 and makes a port of Alamofire much easier.
This PR adds
URLSessionTaskMetricsand its associated types (URLSessionTaskTransactionMetrics, etc.), as well as theurlSession(_:task:didFinishCollecting:)URLSessionTaskDelegatemethod. It does not include: