Add implementation of NSTimeZone.init() with abbreviation #289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
phausler
added a commit
that referenced
this pull request
Mar 21, 2016
Add implementation of NSTimeZone.init() with abbreviation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an implementation of the following NSTimeZone.init() API:
The implementation does a lookup of the abbreviation in the CFTimeZoneAbbreviationDictionary to generate a name and, if found, uses that to create a NSTimeZone instance. If no entry is found, we return nil.
I've also added two tests, one to check the negative (invalid abbreviation) case, and one to check the valid case using "AST" (the first entry in the dictionary).