Remove an invalid numeric JSON test #2903
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The value `2.7976931348623158e+308` is a perfectly valid JSON number and should be accepted. This test is only passing today because the Swift standard library's `Double(_ String:)` initializer has a bug that rejected numbers larger than the maximum Double value. But we're getting ready to fix that bug in the Swift standard library, (swiftlang/swift#34339) which will break this test when it lands.
stephentyrone
approved these changes
Oct 17, 2020
|
@swift-ci test |
spevans
approved these changes
Oct 17, 2020
|
@swift-ci test and merge |
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The value
2.7976931348623158e+308is a perfectly valid JSON numberand should be accepted. This test is only passing today because the Swift
standard library's
Double(_ String:)initializer currently has a bug thatrejects numbers larger than the maximum Double value.
But we're getting ready to fix that bug in the Swift standard library,
(swiftlang/swift#34339) which will break this test when it lands.
(After that PR lands, we should update this again to verify that this value
parses to
Double.infinity.)