[Windows] Add trailing slash to NSTemporaryDirectory result #2910
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NSTemporaryDirectory on Darwin returns path with trailing slash, and almost every test in TestFileManager counts on it.
|
CC @compnerd |
compnerd
approved these changes
Oct 24, 2020
|
@swift-ci please test |
lxbndr
added a commit
to readdle/swift-corelibs-foundation
that referenced
this pull request
Nov 9, 2020
Broken since swiftlang#2910. `validPathSeps` is internal to SwiftFoundation and can't be accessed from Compatibility tests. I think it is ok to define expected values in local scope of test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NSTemporaryDirectory on Darwin returns path with trailing slash, and almost every test in TestFileManager counts on it.
Without slash tests are generating temporary paths like
C:\Users\user\AppData\Temptest_isReadableFile5004BFCF-4356-4000-8000-000000000000, which is, obviously, out of Temp directory.Non-Darwin and non-Windows platforms have already implemented similar workaround, so I just adapted existing solution for Windows.