Improve cleanup in FileManager tests #2911
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
Does it make sense to put these into defer blocks instead at the beginning of the function? |
I believe it would be better with |
lxbndr
force-pushed
the
temporary-for-real
branch
from
9c06b5e to
ea501f4
Compare
compnerd
approved these changes
Oct 27, 2020
spevans
approved these changes
Oct 27, 2020
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of tests in
TestFileManagerdo cleanup of created content, but some are missing it. After several days of re-running Foundation test suite Temp folder is full of abandoned files. While it is not a big deal (this is temp folder after all), I think it is good to be tidy and do some trivial cleanup.This change is complement to #2909