[5.3] Windows, remove obsolete TLS finalization #2917
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Foundation uses Fls now. Fls provides automatic cleanup, and manual finalization on DLL_THREAD_DETACH is not needed.
|
@swift-ci please test |
compnerd
approved these changes
Nov 5, 2020
|
I believe it fixes an elusive crash. We had a stable reproduction rate "in vivo", as our code actively uses dispatch queues. But I could not reproduce it sample app, unfortunately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copied from #2902. The diff is exactly same. Considered safe and worth to port to 5.3.