Skip to content

Partially fixes SR-13831: Warnings while building on Linux. #2919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 12, 2020

Conversation

dhoepfl
Copy link
Contributor

@dhoepfl dhoepfl commented Nov 10, 2020

Fixed lstat warning by including <sys/stat.h>.

Fixed lstat warning by including <sys/stat.h>.
@MaxDesiatov
Copy link
Contributor

Just curious what kind of warning are you referring to?

@dhoepfl
Copy link
Contributor Author

dhoepfl commented Nov 11, 2020

Just curious what kind of warning are you referring to?

On systems that do not define statx, an fallback using lstat is used. The fallback implementation did not import sys/stat.h resulting in implicit declaration of function 'lstat' warnings whenever ForSwiftFoundationOnly.h was imported (I see it 160 times in a full build).

(See my bug report)

@spevans
Copy link
Contributor

spevans commented Nov 11, 2020

@swift-ci test

@spevans
Copy link
Contributor

spevans commented Nov 11, 2020

@dhoepfl Out of curiosity, what version of Linux are you compiling on?

@dhoepfl
Copy link
Contributor Author

dhoepfl commented Nov 11, 2020

@dhoepfl Out of curiosity, what version of Linux are you compiling on?

Debian 10.6 (Buster)

% uname -a
Linux lightblue 4.19.0-10-amd64 #1 SMP Debian 4.19.132-1 (2020-07-24) x86_64 GNU/Linux

@dhoepfl
Copy link
Contributor Author

dhoepfl commented Nov 11, 2020

I do not see why this test failed. It is not related to my change.

(Concurrent.cpp:78 should probably be ASSERT_GE because the reader might run twice before the writer was run again but that one did not trigger here.)

@spevans
Copy link
Contributor

spevans commented Nov 12, 2020

@swift-ci test

@dhoepfl
Copy link
Contributor Author

dhoepfl commented Nov 12, 2020

Another unrelated fail.
Could you trigger another run, please?

(I do not know enough about the build system to understand why this test ever passed.)

@MaxDesiatov
Copy link
Contributor

@swift-ci please test Linux platform

@spevans spevans merged commit d6e1d6e into swiftlang:main Nov 12, 2020
@spevans
Copy link
Contributor

spevans commented Nov 12, 2020

@dhoepfl I think the tests sometimes break because there is some code that is auto-merged into the llvm branches without being unit tested causing the unrelated failures.

@dhoepfl
Copy link
Contributor Author

dhoepfl commented Nov 13, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants