Skip to content

Fix FoundationTest build on macOS #2923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 9, 2020
Merged

Conversation

kgominyuk
Copy link
Contributor

@kgominyuk kgominyuk commented Nov 16, 2020

FoundationTest build on macOS has been broken since #2912.
Compilation fails with error cannot convert value of type 'SwiftError' to type 'NSError' in coercion.
I guess we have to exclude related tests on Darwin platform, but leave them in DarwinCompatibilityTests.

FoundationTest build on macOS has been broken since swiftlang#2912.
Compilation fails with error `cannot convert value of type 'SwiftError' to type 'NSError' in coercion`.
I guess we have to exclude related tests on Darwin platform, but leave them in DarwinCompatibilityTests.
@MaxDesiatov
Copy link
Contributor

@swift-ci please test

@Slayer741
Copy link

Not only Foundationtest;
I ran into a little issue while compiling LLVM+LLDB for mac/ios

i was building on MacOs Big Sur 11.0 (20A5343)
with Xcode 12.3 Beta

} API_AVAILABLE(ios(11.0)) API_UNAVAILABLE(macos, watchos, tvos) NS_SWIFT_NAME(URLSessionConfiguration.MultipathServiceType);
                                                                 ^
/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS14.3.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSURLSession.h:657:66: note: please report this issue to the owners of 'Foundation'
} API_AVAILABLE(ios(11.0)) API_UNAVAILABLE(macos, watchos, tvos) NS_SWIFT_NAME(URLSessionConfiguration.MultipathServiceType);
                                                                 ^
/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS14.3.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSURLSession.h:811:3: warning: imported declaration 'NSURLSessionDelayedRequestDisposition' could not be mapped to 'URLSession.DelayedRequestDisposition'
} NS_SWIFT_NAME(URLSession.DelayedRequestDisposition) API_AVAILABLE(macos(10.13), ios(11.0), watchos(4.0), tvos(11.0));
  ^
/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS14.3.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSURLSession.h:811:3: note: please report this issue to the owners of 'Foundation'
} NS_SWIFT_NAME(URLSession.DelayedRequestDisposition) API_AVAILABLE(macos(10.13), ios(11.0), watchos(4.0), tvos(11.0));

@lxbndr
Copy link
Contributor

lxbndr commented Nov 29, 2020

@Slayer741 Hmm, this looks unrelated to the scope of this patch. We're focused on breaking changes introduced in #2912. It is correct that TestFoundation has other issues when built with latest Xcode. I think they should be addressed separately.

@compnerd compnerd merged commit ab6be65 into swiftlang:main Dec 9, 2020
@kgominyuk kgominyuk deleted the fix/test-nserror branch December 10, 2020 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants