Process: Adapt #2928 for Android #2942
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
Single Linux CI test failure is in the compiler unit tests, unrelated to this pull. |
|
@swit-ci test linux |
|
CI command was misspelled. |
|
@swift-ci test linux |
|
Single Linux CI test failure must be unrelated, as this pull changes nothing on non-Android platforms. |
|
I agree, I just want to see it passing at least once. |
|
@swift-ci test linux |
|
Of course, I was just reporting the problem here so you don't have to dig into the log. |
|
Thanks, I'll submit for the 5.4 branch too. |
This was referenced May 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hit this when trying to cross-compile with swiftlang/swift#33724 for Android with the Dec. 5 trunk source snapshot. I'm going to set up a CI soon for Android cross-compilation of the SDK and some Swift packages for both the trunk and release branches, which will catch such regressions faster.
I ran the tests natively on Android with the Dec. 11 source snapshot and this pull, got the same failing tests as with
this pull#2928 reverted (some URLComponents tests now trap unrelated to this pull).@spevans, would be good to get this in before the 5.4 branch.