SR-13822: FileHandle closeOnDealloc causes a Stack Overflow on Windows #2944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Setting closeOnDealloc to false seems to cause a stack Overflow on Windows so disable the functionality of NOT closing the file, but only on Windows.
|
@swift-ci test |
|
@swift-ci test linux |
|
https://dev.azure.com/compnerd/swift-build/_build/results?buildId=44597&view=results shows that this does repair the test suite. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows so disable the functionality of NOT closing the file, but only
on Windows.
#2932 Causes a stack overflow on windows so disable the functionality and tests on Windows