[SR-999] Add dot to NSString.stringByAppendingPathExtension() result #295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks good to me, the tests seem to cover the issue well. |
phausler
added a commit
that referenced
this pull request
Mar 22, 2016
[SR-999] Add dot to NSString.stringByAppendingPathExtension() result
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for SR-999 which reports that
stringByAppendingPathExtension()andstringByDeletingPathExtension()are failing to add/remove the 'dot' before the extension.I've implemented tests that match the examples given in the API spec, along with an additional test including a tilda, and the modified the relevant functions in
NSPathUtilities.