Set isRunning of Process to false before calling the termination handler
#3000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n handler Otherwise, we end up in a race condition where `isRunning` might still be `true` when accessed from inside the `terminationHandler`. If this is the case, accessing `terminationReason` or `terminationStatus` inside the termination handler crashes because their precondition that the task has finished are not satisfied. Fixes rdar://78035044
|
@swift-ci Please test |
|
@ahoppen Might be good to backport to 5.4 as well since this fixes an obvious bug |
|
@spevans Do you mean to backport to 5.5 or to 5.4 and 5.5? Only back porting to 5.4 doesn’t make sense to me, unless I’m missing something about the corelibs-foundation branching scheme. |
|
Sorry, yes I meant the 5.5 branch. |
|
OK, set up a 5.5 PR here: #3002 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, we end up in a race condition where
isRunningmight still betruewhen accessed from inside theterminationHandler. If this is the case, accessingterminationReasonorterminationStatusinside the termination handler crashes because their precondition that the task has finished are not satisfied.We are experiencing this flaky behavior in SourceKit-LSP’s crash recovery tests on Linux.
Fixes rdar://78035044