[SE-0046] Implemented consistent function labels #305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harlanhaskins
force-pushed
the
se-0046-consistent-func-labels
branch
from
8c4beab to
9b4ee6a
Compare
|
@swift-ci please test |
|
Can't really review this effectively; there are too many diffs. We may have to just merge it and hope for the best. |
|
Also the CI is going to fail because the compiler work hasn't been merged in 😞 |
harlanhaskins
force-pushed
the
se-0046-consistent-func-labels
branch
from
9b4ee6a to
8038d35
Compare
|
@parkera We're going to merge this as soon as the compiler work is merged, to avoid spurious build failures. Is this alright? |
3 tasks
|
@parkera Can I get a merge? |
|
Or @phausler? |
atrick
pushed a commit
to atrick/swift-corelibs-foundation
that referenced
this pull request
Jan 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented changes specified in SE-0046 Establish consistent label behavior across all parameters including first labels
Please look over this and make sure I didn't inadvertently change API. Thanks!