[SR-15156] Another fix for Decimal(sign:exponent:significand:)
.
#3074
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue has been present all along, and my previous fix in #3068 didn't address it because I didn't know of the problem--and (perhaps unsurprisingly) reproduced the same problem despite a totally new implementation of the initializer. Consider the following:
This is because the implementation of
Decimal(sign:exponent:significand:)
converts betweenInt
and an integer type of smaller bit width (but still plenty wide enough to represent more than twice the largest possible exponent) using a trapping initializer instead of clamping.The present PR fixes that oversight now (in both the corelibs and overlay implementations) and adds tests.