Allow Process.waitUntilExit() to be called from any thread
#3113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that if .waitUntilExit() is a different run loop than .run() was called on, .waitUntilExit() won't return before self.isRunning becomes false.
This makes the os(Windows) version of .run() a little easier to read.
pcbeard
changed the title
pcbeard
changed the title
Process.waitUntilExit() to be called from any thread
compnerd
approved these changes
Nov 16, 2021
There was a problem hiding this comment.
LGTM; Please wait for @millenomi to have a look at this as well.
Sources/Foundation/Process.swift
Outdated
| repeat { | ||
|
|
||
| } while( self.isRunning == true && RunLoop.current.run(mode: .default, before: Date(timeIntervalSinceNow: 0.05)) ) | ||
| // |
There was a problem hiding this comment.
Did you intend to add a comment here that you forgot?
There was a problem hiding this comment.
In afa6b1e: Remove stray comment, update self.runLoop to enable earlier wakeup from manager thread.
Remove stray comment
|
@swift-ci test |
parkera
approved these changes
Nov 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR relaxes which thread / runloop
Process.waitUntilExit()can be called from. Before this change, a different thread would return prematurely from.waitUntilExit()withProcess.isRunningstill true. This change fixes the problem by observing whether the.runLoopproperty matchesRunLoop.currentRunLoop, and if it doesn't then it no longer callscurrentRunLoop.run(mode: .default, before: Date(timeIntervalSinceNow: 0.05))which would always returnfalsefor this new thread. Instead, it simply callscurrentRunLoop.run(until: Date(timeIntervalSinceNow: 0.05))and keeps checking the.isRunningproperty.