Process: handle HRESULT exit codes properly
#3121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a process terminates due to an unhandled exception via a `HRESULT`, the process termination status will not have `0xC000_0000` or `0xE000_0000` but rather `0x8000_0000` set. This accounts for that and properly classifies the exit as an abnormal exit. This was identified by the swift-driver test suite not properly detecting an abnormal exit of the frontend.
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a process terminates due to an unhandled exception via a
HRESULT,the process termination status will not have
0xC000_0000or0xE000_0000but rather0x8000_0000set. This accounts for that andproperly classifies the exit as an abnormal exit. This was identified
by the swift-driver test suite not properly detecting an abnormal exit
of the frontend.