Skip to content

Remove additional/redundant case let as Date. #3123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 20, 2022

Conversation

justinmcp
Copy link
Contributor

Case accidentally included twice, remove a copy.

@YOCKOW
Copy link
Member

YOCKOW commented Jan 10, 2022

@swift-ci Please test

@justinmcp
Copy link
Contributor Author

That's a mighty log file. Error seems unrelated though.

/home/buildnode/jenkins/workspace/swift-corelibs-foundation-PR-Linux/swift-docc/Tests/SwiftDocCTests/Indexing/NavigatorIndexTests.swift:250: error: NavigatorIndexingTests.testNavigationTreeLargeDumpAndReadAsync : Asynchronous wait failed - Exceeded timeout of 10.0 seconds, with unfulfilled expectations: Load the tree asynchronously.

@justinmcp
Copy link
Contributor Author

justinmcp commented Jan 11, 2022

FYI, that test reads from a custom binary format, naught to do with JSON. Timing in tests is notoriously difficult, running again is probably the quickest option.

@YOCKOW
Copy link
Member

YOCKOW commented Jan 11, 2022

@swift-ci Please test Linux platform

1 similar comment
@YOCKOW
Copy link
Member

YOCKOW commented Jan 11, 2022

@swift-ci Please test Linux platform

@justinmcp
Copy link
Contributor Author

Different error on latest, a compile error;

/home/buildnode/jenkins/workspace/swift-corelibs-foundation-PR-Linux/swift/test/SILGen/moveonly_builtin.swift:35:11: error: _move applied to value that the compiler does not support checking

Unrelated again.

Pure curiosity, any docs on the testing methodology?

@YOCKOW
Copy link
Member

YOCKOW commented Jan 13, 2022

Pure curiosity, any docs on the testing methodology?

I'm not sure which you mean, but some docs are available such as below:

@YOCKOW
Copy link
Member

YOCKOW commented Jan 13, 2022

@swift-ci Please test Linux platform

@YOCKOW
Copy link
Member

YOCKOW commented Jan 14, 2022

@d-ronnqvist @ethan-kusters @franklinsch (Sorry, I'm not sure whom I should request for opinions.)
Recent tests on Linux for this PR have failed repeatedly because of the error in SwiftDocCTests "NavigatorIndexingTests.testNavigationTreeLargeDumpAndReadAsync : Asynchronous wait failed - Exceeded timeout of 10.0 seconds, with unfulfilled expectations: Load the tree asynchronously" which seems to be unrelated to this PR.
Do you have any ideas?

Logs:

@justinmcp
Copy link
Contributor Author

justinmcp commented Jan 14, 2022

@YOCKOW Thanks for those links.

I'm sure to be biased, I wouldn't be after testing downstream projects like this, for example, so I wanted to read about the testing strategy.

Docs look comprehensive, I'll have a read later tonight, thanks again.

@YOCKOW
Copy link
Member

YOCKOW commented Jan 19, 2022

swiftlang/swift-docc#70 should resolve the CI failure. (Thanks to @d-ronnqvist )

@YOCKOW
Copy link
Member

YOCKOW commented Jan 19, 2022

@swift-ci Please test Linux platform

@YOCKOW YOCKOW merged commit 2254a13 into swiftlang:main Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants