build: allow static linking against ICU data #3129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the removal of the ICU data dependency in swiftCore, it is now possible to statically link to the ICU, with static linking to the ICU data as well. This would allow us to remove the ICU dependency from leaking into distributions which was previously required due to the oversized cost of the ICU data. With the single use now, it is possible to statically link the data to avoid the distribution and packaging. In order to provide a migration path, this needs to be optionalised, and as such, we only link the data if it is found (and can be controlled through `-D ICU_DATA_LIBRARY_RELEASE=`
|
@swift-ci please test |
|
@swift-ci please test macOS platform |
|
Tested on Windows CI: https://dev.azure.com/compnerd/swift-build/_build/results?buildId=56360&view=results That test simply indicates that dynamic linking still works after the change. Actually changing to static linking is something that will need to be done subsequently. |
|
cc @drexin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the removal of the ICU data dependency in swiftCore, it is now
possible to statically link to the ICU, with static linking to the
ICU data as well. This would allow us to remove the ICU dependency
from leaking into distributions which was previously required due to
the oversized cost of the ICU data. With the single use now, it is
possible to statically link the data to avoid the distribution and
packaging. In order to provide a migration path, this needs to be
optionalised, and as such, we only link the data if it is found (and
can be controlled through
-D ICU_DATA_LIBRARY_RELEASE=