Add comparator between two dates ignoring time #313
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In many situations we need a way of comparing if two dates are the same but ignoring time. It’ll be really nice if we provide an easy way of doing that
|
This would be new API, which are are not accepting through PR at this time. We can have a discussion about this on the corelibs mailing list. |
|
As a side note, I don't think this implementation is going to be correct for all calendars... |
|
Ok! Thanks :) |
atrick
pushed a commit
to atrick/swift-corelibs-foundation
that referenced
this pull request
Jan 12, 2021
Revert "Allow double dash for IndexStore-related CLI arguments"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In many situations we need a way of comparing if two dates are the same
but ignoring time. It’ll be really nice if we provide an easy way of
doing that