Skip to content

Foundation: final-ize many bridgeable interfaces #3132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 1, 2022

Conversation

compnerd
Copy link
Member

These are not overridden and are private fields which do not need to be
emitted to the vtable. This allows these members to not impact the
module serialization when @_implementationOnly imports are used for
CoreFoundation by removing them entirely from the serialization path.

These are not overridden and are private fields which do not need to be
emitted to the vtable.  This allows these members to not impact the
module serialization when `@_implementationOnly import`s are used for
CoreFoundation by removing them entirely from the serialization path.
@millenomi
Copy link
Contributor

@swift-ci please test and merge

@compnerd
Copy link
Member Author

@swift-ci please test macOS platform

@compnerd
Copy link
Member Author

Hmm, the macOS builder seems to have triggered an assertion:

Assertion failed: (inserted && "there should be no duplicate decls"), function getDisplayDecls, file Module.cpp, line 967.

@millenomi
Copy link
Contributor

Please test with following PRs:
swiftlang/swift#41115

@swift-ci please test

@compnerd compnerd merged commit b86ea32 into swiftlang:main Feb 1, 2022
@compnerd compnerd deleted the finalized branch February 1, 2022 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants