Write string external representation in String.write(to: URL) #3158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@millenomi Are you able to review this patch, or recommend somebody? |
|
@swift-ci please test and merge |
1 similar comment
|
@swift-ci please test and merge |
|
@swift-ci please test |
|
@millenomi Does this look good to go, then? |
|
@millenomi Not sure what happened to this. CI appears green but it wasn't merged? 🤷 |
parkera
reviewed
Aug 29, 2022
jmschonfeld
approved these changes
Aug 29, 2022
There was a problem hiding this comment.
Yes this looks correct to me. The behavior here which (as you mentioned) is consistent with darwin platforms comes from the Unicode conformance spec which states that the explicit BE/LE encodings should not contain a BOM and the <00 00 FE FF> / <FF FE 00 00> byte sequences should be interpreted as U+FEFF Zero Width No-Break Space (this applies to both the UTF16 and UTF32 variants).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NSString._getExternalRepresentation()was not returning the string's external representation 👀.For some reason, CF decides to only include the BOM in the external representation for encodings using the machine's local endianness (e.g.
.utf16,.utf32) but not if you specify an explicit endianness (e.g..utf32BigEndian). It does the same thing on Darwin Foundation -- I don't know why, and I don't agree with it, and it isn't documented anywhere AFAICT, but there it is.