CoreFoundation: clean up module locator logic #3163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the address of the function to get a module handle without bumping the refcount of the module. This avoids the need to hardcode the library name and enables the use of CoreFoundation in a statically linked fashion as well. We can further reduce the logic by using the PathCch routine to remove the trailing file specification. This reduces the complexity in the module location code and reuses the system libraries for a small additional cost of an additional iteration of the string path.
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the address of the function to get a module handle without bumping
the refcount of the module. This avoids the need to hardcode the
library name and enables the use of CoreFoundation in a statically
linked fashion as well. We can further reduce the logic by using the
PathCch routine to remove the trailing file specification. This reduces
the complexity in the module location code and reuses the system
libraries for a small additional cost of an additional iteration of the
string path.