CoreFoundation: correct alignment mis-assumption #3164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The allocator on 32-bit platforms are not guaranteed to provide a 16-byte alignment. This would cause an over-aligned request which would be serviced by a different allocation path which needs to be paired with an appropriate deallocation invocation. Failure to do so resulted in a heap corruption on Windows i686.
|
@swift-ci please test |
|
Is there a way (even if non-portable?) to get the malloc alignment without having to hardcode it this way? |
|
For posterity: no, from a cursory search. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The allocator on 32-bit platforms are not guaranteed to provide a
16-byte alignment. This would cause an over-aligned request which would
be serviced by a different allocation path which needs to be paired with
an appropriate deallocation invocation. Failure to do so resulted in a
heap corruption on Windows i686.