Clarify where NSCalendar timezone is set and return values #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syoutsey
changed the title
|
This looks ok, but can you fix up the whitespace and rebase before we merge? |
|
Done, thanks! |
|
Great - just go ahead and rebase this into 1 commit and I'll merge it in. Thanks. |
| @@ -368,7 +368,9 @@ public class NSCalendar : NSObject, NSCopying, NSSecureCoding { | |||
| let oldTz = timeZone | |||
There was a problem hiding this comment.
all these lines could be self.timeZone = timeZone ?? comps.timeZone
Fixed whitespacing issues Merge timeZone assignment into more clear single operation
|
@jpsim Great idea, though it looks like the operands are out of order. Fixed and rebased. Thanks! |
parkera
added a commit
that referenced
this pull request
Dec 5, 2015
Clarify where NSCalendar timezone is set and return values
|
Looks good. |
atrick
pushed a commit
to atrick/swift-corelibs-foundation
that referenced
this pull request
Jan 12, 2021
[build] Update xcconfig overrides with workarounds from SR-9292
kateinoigakukun
pushed a commit
to kateinoigakukun/swift-corelibs-foundation
that referenced
this pull request
Apr 29, 2021
[REPL] Test RPATH is set correctly on linux.
kateinoigakukun
pushed a commit
to kateinoigakukun/swift-corelibs-foundation
that referenced
this pull request
Oct 11, 2023
[pull] swiftwasm from master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flow is more logical and easy to follow by setting
timezoneimmediately after declaration. Additionally, return values more closely follow idioms specified here.