[swift-3-indexing-model] porting Foundation to the new indexing model #339
+109
−87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| T.Iterator.Element == T2.Iterator.Element, | ||
| T.SubSequence.Iterator.Element == T.Iterator.Element, | ||
| T.Indices.Iterator.Element == T.Index | ||
| >(_ subSequence : T2, inSequence seq: T,anchored : Bool) -> T.Index? { |
There was a problem hiding this comment.
Let's leave this patch to fundamentals and not changing of the coding style.
There was a problem hiding this comment.
Fixed, pushed an update.
|
Looks ok to me except for the minor comment about the code style change. Merge when you're ready. |
gribozavr
force-pushed
the
swift-3-indexing-model
branch
from
b713feb to
fdfdd38
Compare
|
Thanks @parkera! |
|
foundation fails to build due to below compilation error. |
|
@mbvreddy How are you building? What git hashes do you have checked out? The buildbots were happy since I merged it: https://ci.swift.org/job/oss-swift-incremental-RA-linux-ubuntu-14_04/4510/ |
|
@gribozavr |
atrick
pushed a commit
to atrick/swift-corelibs-foundation
that referenced
this pull request
Jan 12, 2021
Don't log the sourcekit code complete request
kateinoigakukun
pushed a commit
to kateinoigakukun/swift-corelibs-foundation
that referenced
this pull request
Oct 11, 2023
[pull] swiftwasm from main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains adjustments for SE-0065 "A New Model for Collections and Indices".