Fix up swift-corelibs-foundation for abolition of IUO type in SE-0054 #343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
| @@ -971,28 +971,28 @@ extension NSString { | |||
| } | |||
|
|
|||
| public var decomposedStringWithCanonicalMapping: String { | |||
| let string = CFStringCreateMutable(kCFAllocatorSystemDefault, 0) | |||
| let string = CFStringCreateMutable(kCFAllocatorSystemDefault, 0)! | |||
There was a problem hiding this comment.
It's not clear to me why the result here is nullable in the first place...
There was a problem hiding this comment.
CFStringCreateMutable appears to have IUO return type when imported. Maybe it hasn't been annotated for nullability.
|
Merge when ready |
|
Thanks! |
atrick
pushed a commit
to atrick/swift-corelibs-foundation
that referenced
this pull request
Jan 12, 2021
Workaround SR-13822 by keeping the file handle alive for the connection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes up swift-corelibs-foundation for when SE-0054 is merged into swift master. See swiftlang/swift#2322. The two PRs are to be merged in conjunction.