NSTask - capture output from commands #348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| public var standardInput: AnyObject? { | ||
| willSet { | ||
| guard newValue is NSPipe || newValue is NSFileHandle else { | ||
| abort() |
There was a problem hiding this comment.
Let's change this (and following) to preconditionFailure("message") instead, so a caller knows what they did wrong without digging into the source code.
|
@swift-ci please test |
|
Ah yes, that's way better. I've updated the PR. |
|
Looks good, thanks! |
|
@swift-ci please test |
5 tasks
atrick
pushed a commit
to atrick/swift-corelibs-foundation
that referenced
this pull request
Jan 12, 2021
Currently `FileSystemError` doesn't have an associated path, which makes diagnosing errors harder. This is going to be fixed in TSC and SwiftPM, but this is a breaking change. Usage of `FileSystemError` is updated in the SourceKit-LSP codebase accordingly.
kateinoigakukun
pushed a commit
to kateinoigakukun/swift-corelibs-foundation
that referenced
this pull request
Oct 11, 2023
[pull] swiftwasm from main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.