Implement basic geometry functions #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| extension CGSize: Equatable { } | ||
|
|
||
| public func ==(lhs: CGSize, rhs: CGSize) -> Bool { | ||
| return (lhs.width == rhs.width) && (lhs.height == lhs.height) |
There was a problem hiding this comment.
lhs.height == lhs.height is always true. You want lhs.height == rhs.height
|
Let's rebase this after incorporating @johankool 's comments so we can merge it in. Thanks! |
|
Done, thanks! |
| @@ -66,6 +88,12 @@ public struct CGRect { | |||
| } | |||
| } | |||
|
|
|||
| extension CGRect: Equatable { } | |||
|
|
|||
| public func ==(lhs: CGRect, rhs: CGRect) -> Bool { | |||
There was a problem hiding this comment.
This functionality on Darwin actually lives in CoreGraphics not in Foundation
|
Looks fine to me. |
phausler
added a commit
that referenced
this pull request
Dec 7, 2015
Implement basic geometry functions
atrick
pushed a commit
to atrick/swift-corelibs-foundation
that referenced
this pull request
Jan 12, 2021
[test] Remove defunct `static var allTests` everywhere
kateinoigakukun
pushed a commit
to kateinoigakukun/swift-corelibs-foundation
that referenced
this pull request
Apr 29, 2021
Add integration test for testing SwiftPM's code coverage support
kateinoigakukun
pushed a commit
to kateinoigakukun/swift-corelibs-foundation
that referenced
this pull request
Oct 11, 2023
[pull] swiftwasm from master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented some basic geometry functions