Adding support for ARMv6 on linux #352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This successfully built on the un-official swift-arm CI infrastructure. It should be NFC on any other arch. LGTM. |
|
@swift-ci please test |
|
Just to make sure we didn't mess something up for the other build platforms, I'll kick off a CI run. |
atrick
pushed a commit
to atrick/swift-corelibs-foundation
that referenced
this pull request
Jan 12, 2021
SKSwiftPMWorkspace: make `testBasicCXXArgs` pass on Windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change expands on the work by @hpux735 to support ARMv6, not just ARMv7.
While making the change I noticed the ArchSubType class (which already has a bunch of ARM architectures listed). That might be a more robust change...but ArchSubType doesn't look like its used anywhere, so I did this quicker solution that I know works.
Thoughts on whether it is worth it to try an implementation with the
armArchType, and manage the v6 or v7 in theArchSubType? It makes things more complicated (have to add asubarchtoTarget, etc), so maybe better just use ArchType only (as I have done here)?