implementation for NSURL.standardizedURL and NSURL.filePathURL properties #360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -28,6 +28,40 @@ private func _standardizedPath(_ path: String) -> String { | |||
| return path | |||
| } | |||
|
|
|||
| /* internal function to remove .. and . from path */ | |||
| internal func _standardizedURLPath(_ path: String) -> String { | |||
There was a problem hiding this comment.
This should be private actually.
|
Right. I will change and squash it now. |
|
@parkera I've implemented the changes suggested. |
|
@swift-ci please test |
|
I'm in process of resolving conflicts by re-basing and recompiling. |
|
resolved conflicts |
|
@parkera After rebasing, I changed the fix and considered your earlier suggestions. Please review. |
|
@parkera please review |
|
@swift-ci please test |
|
Thanks for the ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation for NSURL.standardizedURL and NSURL.filePathURL is added and enabled tests for NSURL.standardizedURL in TestNSURL.swift