Add implementation for NSURL copy() #382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| func test_copy() { | ||
| let url = NSURL(string: "https://www.swift.org") | ||
| let urlCopy = url!.copy() as! NSURL | ||
| XCTAssertTrue(url === urlCopy) |
There was a problem hiding this comment.
This requires that the url instance is the same as the other; we may change that in the future. I would prefer the test checks a property of the URL for equality, or even better calls into URL's isEqual
|
@parkera I've squashed suggested changes. Please check. |
check for isEqual in testcase instead of identical operator
|
@parkera can this be merged? |
|
Yes, this should be good. |
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has below implementations along with testcase
NSURL.copyWithZone()
NSURLQueryItem.copyWithZone()