Changed the NSOrderedSet to use NSMutableArray and NSMutableSet internally #385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| public func enumerateObjectsWithOptions(_ opts: NSEnumerationOptions, usingBlock block: (AnyObject, Int, UnsafeMutablePointer<ObjCBool>) -> Void) { NSUnimplemented() } | ||
| public func enumerateObjectsAtIndexes(_ s: NSIndexSet, options opts: NSEnumerationOptions, usingBlock block: (AnyObject, Int, UnsafeMutablePointer<ObjCBool>) -> Void) { NSUnimplemented() } | ||
| public var array: [AnyObject] { | ||
| return _orderedStorage.bridge() |
There was a problem hiding this comment.
This is probably good enough for now, because it's busted on Darwin too - but note that the comment here describes this class as returning a proxy object for this method and also set. The bridge does a copy, so no proxying is happening.
There was a problem hiding this comment.
Yeah. I didn't come up with any solution here. Thus return just a copy of the array/set. Will work on implementing other NSOrderedSet methods and think over about improving these ones then.
|
@swift-ci please test |
|
Unfortunately this became out of date. Is it possible to rebase? |
|
Finally did rebase on current master branch. |
|
This has gone stale. Please rebase and reopen if necessary. |
kateinoigakukun
pushed a commit
to kateinoigakukun/swift-corelibs-foundation
that referenced
this pull request
Oct 11, 2023
[pull] swiftwasm from main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NSOrderedSetAPI contains lots of methods similar to the ones we have inNSSet&NSArray. I'd consider using these collections instead of the Swift ones in theNSOrderedSet/NSMutabeOrderedSetimplementation.