Skip to content

Implementing preflight(),loadWithErrorin NSBundle #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 28, 2016

Conversation

saiHemak
Copy link
Contributor

Also includes the fix for segmentation fault issue when the NSBundle is created with an invalid path

public func preflight() throws { NSUnimplemented() }
public func loadAndReturnError() throws { NSUnimplemented() }
public func preflight() throws {
var unmangaedError:Unmanaged<CFError>? = nil
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo.

“saiHemak” added 2 commits June 24, 2016 16:04
Also includes the fix for segmentation fault issue when the NSBundle is created with an invalid path
@saiHemak saiHemak force-pushed the nsbundleload-branch branch from 7407d74 to c99db1a Compare June 24, 2016 11:28
@saiHemak
Copy link
Contributor Author

@ianpartridge Changes are done as per your comments

@parkera
Copy link
Contributor

parkera commented Jun 28, 2016

@swift-ci please test

@parkera parkera merged commit 0ae2e28 into swiftlang:master Jun 28, 2016
@saiHemak saiHemak deleted the nsbundleload-branch branch June 28, 2016 16:28
kateinoigakukun pushed a commit to kateinoigakukun/swift-corelibs-foundation that referenced this pull request Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants