Implementation of HTTPCookie.cookies(withResponseHeaderFields:forURL:) #423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This if for an initial implementaion of HTTPCookie.cookies(withResponseHeaderFields:forURL:). In addition to the contributed unit tests, I have also tested this code against cookies returned by some of the twenty most popular websites. Kindly review and provide feedback.
| //Bake a cookie | ||
| private class func createHttpCookie(url: URL, pairs: [String], start: Int, end: Int) -> HTTPCookie? { | ||
| var properties: [String:Any] = [:] | ||
| for index in start..<end { |
There was a problem hiding this comment.
Any reason not to just use for aPair in pairs?
There was a problem hiding this comment.
Oh I see, we're parsing a subset of the array. I think it might be cleaner to just pass an ArraySlice into this.
|
This looks great, thanks. I'm going to kick off a test run while I review further. |
|
@swift-ci please test |
|
Thanks, I'll continue working on the improvements you suggested |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for an initial implementaion of HTTPCookie.cookies(withResponseHeaderFields:forURL:).
In addition to the contributed unit tests, I have also tested this code against cookies
returned by some of the twenty most popular websites.
Kindly review and provide feedback.