Activate the ability to integrate libdispatch #424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok - so we don't need to wait for libdispatch to be in Swift CI before merging this right? |
|
@swift-ci please test |
|
My latest pulls this afternoon had it building for Linux iirc |
|
Cool, sounds like we're almost there. |
|
Merging this will add libdispatch into Foundation (and thereby into Swift PM and XCTest) in the following Swift CI builds: If those run clean (i.e., the tests for Foundation, XCTest and SwiftPM pass), within just need to add libdispatch into the full package builds. |
|
Thanks @seabaylea! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@parkera @phausler This uncomments the block that configures the use of libdispatch by Foundation in build.py, activating the
__HAS_DISPATCH__guard.The block includes guards to check that libdispatch is being built, which means that the toolchain builds in the CI environment won't be affected by this yet.
It will affect the libdispatch CI build, which also builds Foundation, XCTest and Swift PM, so we'll start to exercise the use of libdispatch via TestFoundation and the XCTest and Swift PM unit tests.
If the libdispatch CI builds run clean/stable, we'll then look at adding libdispatch into the toolchain builds via the "buildbot_linux" preset.